-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-throw-literal] add options to to disallow any
/unknown
#4207
feat(eslint-plugin): [no-throw-literal] add options to to disallow any
/unknown
#4207
Conversation
Thanks for the PR, @hedgepigdaniel! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: c8e8941 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/619c6d31544b6c00073e3443 😎 Browse the preview: https://deploy-preview-4207--typescript-eslint.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
+ Coverage 92.76% 93.37% +0.60%
==========================================
Files 332 152 -180
Lines 11524 8056 -3468
Branches 3285 2587 -698
==========================================
- Hits 10690 7522 -3168
+ Misses 361 179 -182
+ Partials 473 355 -118
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯. Thanks!
any
/unknown
PR Checklist
Overview
This PR adds the following options to
@typescript-eslint/no-throw-literal
:When enabled, these rules result in an error being generated from code such as:
This is useful when using this rule to prevent the
throw
ing of values that aren't instances ofError
- because values of typeany
andunknown
are not necessarily instances ofError
.The default values have the same behaviour as the current code.